Unneccasary code causes gcc to fail due to -Werror flags

Description

options.cpp:266:28: error: comparison of unsigned expression >= 0 is always true
[-Werror,-Wtautological-compare]
if (optvallen_ >= 0 && optvallen_ < 256 && optval_ != NULL) {
~~~~~~~~~~ ^ ~
options.cpp:280:28: error: comparison of unsigned expression >= 0 is always true
[-Werror,-Wtautological-compare]
if (optvallen_ >= 0 && optvallen_ < 256 && optval_ != NULL) {

optvallen >=0 is unneeded as optvallen is unsigned so test will create a warning which is marked as error due to -Werror.

Simply fix is to remove test from lines 266 and 280

Environment

Linux gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3, Linux ubuntu 3.8.0-21-generic #32-Ubuntu SMP Tue May 14 22:17:37 UTC 2013 i686 i686 i686 GNU/Linux

Assignee

Unassigned

Reporter

Terry Sheehy

Labels

None

Components

Affects versions

Priority

Major
Configure