socket_t class included in C++ bindings throws exceptions in destructor

Ok. Thanks for such a quick response!

The only possible failure here is failure of zmq_close() function. The documentation mentions only a single possible error:

ENOTSOCK
The provided socket was invalid.

I think we can safely assert on that condition.

... that being said, I never actually encountered a failed close. The only reason I raised the issue, is that design-wise, using shared_ptr with a class that can throw an exception in destructor is bad. So assert would suffice too.

I'd use assert in cases where the error can not be handled and/or can lead to unexpected behavior.
In cases like this one, where the application closes/destroys the socket for cleanup reasons, there is no unexpected behavior possible. Crashing the application for this reason would be an overkill IMHO.

I'd prefer the destructor to catch error_t. And if I want to make sure that socket closes correctly, I can just try ... socket->close(...) ... catch.

What about replacing the code in socket_t::close() function with something like this:

int rc = zmq_close (ptr);
assert (rc == 0);